Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sylabs/sif through v2.13.0 #202

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Aug 24, 2023

This brings apptainer/sif up to date with sylabs sif v12.13.0, pulling in changes from

Original commit descriptions were:

Bump module Go version to 1.20. Advance Go range tested in CI to 1.20-1.21. (Re-)adopt multi-error wrapping in a couple of locations.

As of v1.4.4, go-errorlint exempts Is methods from type assertions (see polyfloyd/go-errorlint#50).

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
…0112148-e01326fd72eb to v0.0.0-20230717121422-5aa5874ade95

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
As of v1.4.4, go-errorlint exempts `Is` methods from type assertions
(see polyfloyd/go-errorlint#50).

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #202 (4639822) into main (306f182) will increase coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   72.96%   72.98%   +0.02%     
==========================================
  Files          35       35              
  Lines        2955     2950       -5     
==========================================
- Hits         2156     2153       -3     
+ Misses        644      642       -2     
  Partials      155      155              
Flag Coverage Δ
unittests 72.98% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/integrity/metadata.go 58.51% <ø> (+0.85%) ⬆️
pkg/integrity/select.go 75.21% <ø> (-0.22%) ⬇️
pkg/integrity/verify.go 80.00% <ø> (-0.06%) ⬇️
pkg/sif/descriptor_input.go 86.88% <ø> (-0.08%) ⬇️
pkg/integrity/digest.go 91.42% <100.00%> (ø)
pkg/integrity/dsse.go 72.07% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DrDaveD DrDaveD merged commit b2c55f5 into apptainer:main Sep 4, 2023
2 checks passed
@DrDaveD DrDaveD deleted the sylabsv2.13.0 branch September 4, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants